(feat) Add tools, memory, structured output, and multi-agent handoff support - #46
Merged
Merged
Conversation
rrr63
requested changes
Sep 24, 2026
Comment on lines
+55
to
+103
|
|
||
| /** | ||
| * Register tool objects (classes carrying #[AsTool] on themselves) the | ||
| * model may call during execute()/stream(). Each | ||
| * | ||
| * @param array<int, object> $tools | ||
| * @return static | ||
| */ | ||
| public function withTools(array $tools): static; | ||
|
|
||
| /** | ||
| * Register memory providers whose content is injected into the system | ||
| * prompt before every call, giving the model persistent/contextual | ||
| * information beyond the current message history. | ||
| * | ||
| * @param iterable<MemoryProviderInterface> $memoryProviders | ||
| * @return static | ||
| */ | ||
| public function withMemory(iterable $memoryProviders): static; | ||
|
|
||
| /** | ||
| * Request the model's response be constrained to, and deserialized into, the given shape | ||
| * | ||
| * @param string|object|null $responseFormat | ||
| * @return static | ||
| */ | ||
| public function asStructured(string|object|null $responseFormat): static; | ||
|
|
||
| /** | ||
| * The agent's name, used to identify it in MultiAgent handoff routing | ||
| * | ||
| * @return string | ||
| */ | ||
| public function getName(): string; | ||
|
|
||
| /** | ||
| * Set the agent's name (see getName()). | ||
| * | ||
| * @param string $name | ||
| * @return static | ||
| */ | ||
| public function named(string $name): static; | ||
|
|
||
| /** | ||
| * Expose the underlying Symfony AI agent | ||
| * | ||
| * @return SymfonyAgentInterface | ||
| */ | ||
| public function toAgent(): SymfonyAgentInterface; |
Member
There was a problem hiding this comment.
It could break some custom agents created by users. We should write the breaking change in the docs (or just tell them to add the missing functions)
Comment on lines
+196
to
+222
| public function toAgent(): SymfonyAgentInterface | ||
| { | ||
| if (null !== $this->agent) { | ||
| return $this->agent; | ||
| } | ||
|
|
||
| $inputProcessors = []; | ||
| $outputProcessors = []; | ||
|
|
||
| if ([] !== $this->memoryProviders) { | ||
| $inputProcessors[] = new MemoryInputProcessor($this->memoryProviders); | ||
| } | ||
|
|
||
| if ([] !== $this->tools) { | ||
| $toolProcessor = new AgentProcessor(new Toolbox($this->tools)); | ||
| $inputProcessors[] = $toolProcessor; | ||
| $outputProcessors[] = $toolProcessor; | ||
| } | ||
|
|
||
| return $this->agent = new SymfonyAgent( | ||
| $this->getPlatform(), | ||
| $this->model, | ||
| $inputProcessors, | ||
| $outputProcessors, | ||
| $this->getName(), | ||
| ); | ||
| } |
Member
There was a problem hiding this comment.
toAgent() does not preserve the format set by asStructured(). Please fix this or add a test covering asStructured()->toAgent()->call()
they should behave the same :
$agent->asStructured(MyDto::class)->execute([]);
$agent->asStructured(MyDto::class)->toAgent()->call($messages);execute() preserves MyDto::class, while toAgent()->call() ignores it.
Comment on lines
+185
to
+191
| public function named(string $name): static | ||
| { | ||
| $this->name = $name; | ||
| $this->agent = null; | ||
|
|
||
| return $this; | ||
| } |
Member
There was a problem hiding this comment.
add this to match with MultiAgent.php and to be sure name is not empty
if ('' === $name) {
throw new RuntimeException('$name must not be empty.');
}
Member
Author
|
@rrr63 I think all are ok now |
rrr63
approved these changes
Sep 25, 2026
rrr63
left a comment
rrr63
left a comment
Member
There was a problem hiding this comment.
all seems ok to me, thank you @techmahedy
Member
Author
Yes, locally tested manually, all seems ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the duplicated platform-building/message-hydration/execute/stream logic out of the five provider classes (Claude, Gemini, OpenAI, OpenRouter, SelfHost) into a new shared AbstractAgent base class, and uses that consolidation to wire in Symfony AI's Agent pipeline — unlocking tool calling, persistent memory, structured output, and multi-agent handoff, none of which the old per-provider implementation could support
Changes