Skip to content

🔀 :: [#824] - 애플리케이션 컨테이너 롤백 로직 리펙토링 - #829

Merged
dolong2 merged 5 commits into
developfrom
fix/application-container-rollback
Aug 10, 2026
Merged

🔀 :: [#824] - 애플리케이션 컨테이너 롤백 로직 리펙토링#829
dolong2 merged 5 commits into
developfrom
fix/application-container-rollback

Conversation

@dolong2

@dolong2 dolong2 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

개요

  • 애플리케이션의 컨테이너 생성 실패 혹은 파일 생성중 실패인 경우 롤백하는 케이스를 리펙토링합니다.

작업내용

  • 컨테이너 생성중 네트워크 연결 실패시 컨테이너 리소스 회수
  • 애플리케이션 리프레시중 컨테이너 생성에 실패한다면 생성된 이미지 제거
  • 코루틴내에서 취소 대신 예외를 던지도록 수정
  • 기존 코루틴 사용처에 SupervisorJob 적용

체크리스트

탬플릿외에 필요한 항목이 있으면 추가해주세요.

  • 로컬에서 빌드가 성공하나요?
  • 추가(수정)한 코드가 정상적으로 동작하나요?
  • pr 타켓 브랜치가 맞게 설정되어 있나요?
  • pr에서 작업할 내용만 작업됐나요?
  • 기존 API와 호환되지 않는 사항이 있나요?

@dolong2 dolong2 self-assigned this Aug 10, 2026
@dolong2 dolong2 added 1️⃣ Priority: 상 우선순위 상 🔨 Refactor 코드 리팩토링 labels Aug 10, 2026
@dolong2 dolong2 linked an issue Aug 10, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@dolong2, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 2 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 32dfc64b-1548-4cc7-bf9f-834ee981f104

📥 Commits

Reviewing files that changed from the base of the PR and between 2ed2898 and 5f6ff2e.

📒 Files selected for processing (10)
  • src/main/kotlin/com/dcd/server/core/domain/application/service/impl/DeleteApplicationDirectoryServiceImpl.kt
  • src/main/kotlin/com/dcd/server/core/domain/application/service/impl/RefreshApplicationServiceImpl.kt
  • src/main/kotlin/com/dcd/server/core/domain/application/usecase/CreateApplicationUseCase.kt
  • src/main/kotlin/com/dcd/server/core/domain/application/usecase/DeployApplicationUseCase.kt
  • src/main/kotlin/com/dcd/server/core/domain/application/usecase/RunApplicationUseCase.kt
  • src/main/kotlin/com/dcd/server/core/domain/application/usecase/StopApplicationUseCase.kt
  • src/main/kotlin/com/dcd/server/core/domain/application/usecase/UpdateApplicationUseCase.kt
  • src/main/kotlin/com/dcd/server/core/domain/auth/usecase/AuthMailSendUseCase.kt
  • src/main/kotlin/com/dcd/server/infrastructure/domain/application/adapter/ApplicationImageFileAdapter.kt
  • src/main/kotlin/com/dcd/server/infrastructure/global/thirdparty/docker/DockerCommandExecutor.kt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dolong2
dolong2 merged commit 7f51210 into develop Aug 10, 2026
2 checks passed
@dolong2
dolong2 deleted the fix/application-container-rollback branch August 10, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 Refactor 코드 리팩토링 1️⃣ Priority: 상 우선순위 상

Projects

None yet

Development

Successfully merging this pull request may close these issues.

애플리케이션 컨테이너 롤백 기능 리펙토링

1 participant