Add 3 GameAudio::Main methods implementation#47
Conversation
cristian64
left a comment
There was a problem hiding this comment.
I've checked that the three implementations show 100% in objdiff.
|
Thanks for your first contribution! There are a few things i'd like being addressed and that's mainly that i'd rather have PRs per file/TU now that this project still has many files that have no work done to it(So this will change in the future). Most of these issues are also kinda on me for not having a contributors guide so my apologies. |
Report for MarioClub_us (8a91a6b - 96e2dc3)📈 Matched code: 45.72% (+0.01%, +168 bytes) ✅ 3 new matches
📉 1 regression in an unmatched item
|
|
Hello and thanks for taking the time to review my PR. I hope my latest changes will match with what you expected. |
GameAudio::Main::bootDSPGameAudio::Main::isActiveGameAudio::Main::isWaveLoaded