Skip to content

Check for completed but unlinked units in CI#2913

Merged
ribbanya merged 5 commits into
doldecomp:masterfrom
ribbanya:pr/build
Jul 19, 2026
Merged

Check for completed but unlinked units in CI#2913
ribbanya merged 5 commits into
doldecomp:masterfrom
ribbanya:pr/build

Conversation

@ribbanya

Copy link
Copy Markdown
Collaborator

No description provided.

@decomp-dev

decomp-dev Bot commented Jul 19, 2026

Copy link
Copy Markdown

Report for GALE01 (5cb15a4 - 65ba96c)

No changes

@ribbanya
ribbanya marked this pull request as ready for review July 19, 2026 20:15

@r-burns r-burns left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is erroring out on a case that is nontrivial, and I don't see why this needs to be an error anyway

@ribbanya

Copy link
Copy Markdown
Collaborator Author

Is it non-trivial? master has only one such case and I'm almost finished with it, I just got side-tracked by this PR. I don't really see a reason not to automate the check, since people are frantically checking the wiki for it anyway.

@ribbanya
ribbanya dismissed r-burns’s stale review July 19, 2026 23:17

CI no longer fails if check fails

@ribbanya
ribbanya merged commit 56394fc into doldecomp:master Jul 19, 2026
13 checks passed
@ribbanya
ribbanya deleted the pr/build branch July 19, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants