Repository navigation
fix(release): use app tokens and handle applied Mesa patches - #1091
Merged
Merged
Conversation
ilopezluna
approved these changes
Oct 21, 2026
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path=".github/workflows/release.yml" line_range="543" />
<code_context>
--repo docker/inference-engine-llama.cpp \
--workflow release-cli-dd.yml \
- --limit 1 --json databaseId --jq '.[0].databaseId // 0' 2>/dev/null || echo "")
+ --limit 1 --json databaseId --jq '.[0].databaseId // 0' || echo "")
case "$BEFORE_ID" in
''|*[!0-9]*)
</code_context>
<issue_to_address>
**Wrong release run is selected**
When another dispatch of the same downstream workflow occurs before the first run-list poll, `RUN_ID` can identify that other dispatch, so the Desktop job reports success without waiting for this release or packaging publishes the other run’s image as this release’s output.
Correlate the downstream run with this release’s dispatch instead of selecting the newest run ID greater than `BEFORE_ID`.
Also at `.github/workflows/release.yml:567`, `.github/workflows/release.yml:591`, `.github/workflows/release.yml:696`.
</issue_to_address>| --repo docker/inference-engine-llama.cpp \ | ||
| --workflow release-cli-dd.yml \ | ||
| --limit 1 --json databaseId --jq '.[0].databaseId // 0' 2>/dev/null || echo "") | ||
| --limit 1 --json databaseId --jq '.[0].databaseId // 0' || echo "") |
Contributor
There was a problem hiding this comment.
🟡 Medium · Wrong release run is selected
When another dispatch of the same downstream workflow occurs before the first run-list poll, RUN_ID can identify that other dispatch, so the Desktop job reports success without waiting for this release or packaging publishes the other run’s image as this release’s output.
Correlate the downstream run with this release’s dispatch instead of selecting the newest run ID greater than BEFORE_ID.
Also at .github/workflows/release.yml:567, .github/workflows/release.yml:591, .github/workflows/release.yml:696.
Prompt for AI agents
In `.github/workflows/release.yml` at line 543:
**Wrong release run is selected**
When another dispatch of the same downstream workflow occurs before the first run-list poll, `RUN_ID` can identify that other dispatch, so the Desktop job reports success without waiting for this release or packaging publishes the other run’s image as this release’s output.
Correlate the downstream run with this release’s dispatch instead of selecting the newest run ID greater than `BEFORE_ID`.
Also at `.github/workflows/release.yml:567`, `.github/workflows/release.yml:591`, `.github/workflows/release.yml:696`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.2.9 release failed before dispatching the Desktop CLI workflow because it still used
CLI_RELEASE_PAT. The ARM64 CPU image also failed because Mesa 26.0.8 already contains the changes from the first Venus patch.Generate repository-scoped GitHub App tokens separately for Desktop, packaging, and deployment. Poll workflow run metadata with Actions permission instead of using
gh run watch, which also requires Checks access. Bound waits below the installation token lifetime and preserve API error output.Check Mesa patches in both directions: apply missing patches, skip confirmed already-applied patches, and fail on incompatible or partially applied patches.
Validation:
make validate-allpassed, including module tidiness, lint, race tests, ShellCheck, and version consistency.Before running the updated workflow, configure repository variable
CLI_RELEASE_APP_ID(4302285) and secretCLI_RELEASE_APP_PRIVATE_KEY. The app installation needs access toinference-engine-llama.cpp,packaging, andrelease-repo, with Actions read/write. A full release build has not been run. Start a new release run after merging; rerunning the original run retains its old workflow revision.