Repository navigation
docs(compose): drop the comments that still describe the deleted imperative start path - #14398
Merged
ndeloof merged 4 commits intoOct 27, 2026
Merged
Conversation
… start path startService and startServiceContainer were removed by the migration of compose start to the plan engine, yet many comments still cite them, or isNotRunning, or describe the start as walked by InDependencyOrder. Rewrite them to state the behavior itself, and fix the ones that say which commands still walk the dependency order. Comments only: the token stream of every Go file, comments excluded, is unchanged. Part of docker#14081 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Same cleanup as the previous commit, for the comments of the unit tests: they cite startService, isNotRunning and the "old imperative engine" as the source of a behavior the plan now owns. Comments only: the token stream of every Go file, comments excluded, is unchanged. Part of docker#14081 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Follow-up of the two previous commits, from their review: rewrap the comments they left with an orphan line, give two of them back a subject, point one at the plan's wait nodes, and drop the "imperative engine" wording of the restart tests, restart being the one command that still walks the dependency order itself. Comments only: the token stream of every Go file, comments excluded, is unchanged. Part of docker#14081 Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
startMx works around duplicate published host ports on Engine 28.0 to 28.2 (docker#12846), a daemon port-allocator flaw fixed in Engine 28.3.0 (moby/moby#50054). Say so in its comment, state which start paths take it, and add a TODO to remove it once Engine 28.x is out of support. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
dock-tor
approved these changes
Oct 27, 2026
24 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does, in one sentence
Rewrites the comments of
pkg/composethat still describe the imperative start path deleted by the migration ofcompose startto the plan engine, without touching a line of code.Context
startServiceandstartServiceContainerare gone sincecompose startruns on a start-only plan (#14296). About fifty comments, in the reconciler, the executor,start/upand their tests, still cite them — orisNotRunning, or a start "walked byInDependencyOrder" — as the source of a behavior the plan now owns. A reader looking for those functions finds nothing, and a few comments say which commands still walk the dependency order, which is no longer true (onlyrestart,stop,downand the classic build do).What the PR brings
compose startstays silent on a no-op, why the wait timeout applies without--wait, …) and dropping the migration history (review-finding anecdotes, "the old engine").service_containers.goand a few helper comments now name the commands that really still use the dependency order.startMxnow ties the mutex to [BUG] docker engine and desktop expose random ports differently #12846 and states that Engine 28.3.0 fixed the cause (Avoid selecting duplicate host ports for mappings to 0.0.0.0 and specific addresses moby/moby#50054), so that it can be found and removed once Engine 28.x is out of support. It also says which start paths take it: the plan executor's only, not restart, run, the relay or the hook runners, which the previous wording claimed.//go:,//nolint), no test changed. Four commits — production comments, test comments, a rewrap that follows their review, and thestartMxannotation — so each reads on its own.Why this is no functional change
//comment line.pkg/,cmd/andinternal/, comments excluded, is identical before and after (a control mutation of onereturnis detected by the same check).mainand from this branch have the same symbols, sizes and types; only the line tables (runtime.pclntab,runtime.epclntab) and the VCS stamp of the build info differ, as expected when comment lines move.go vet,gofmtand the linter are unchanged (only the known findings), andgo test ./pkg/... -racepasses exceptpkg/watch, which fails the same way onmain.example-providerin thePATH, andTestComposeModel).Part of #14081 (Lot 3). The other half of the lot — moving the dependency-wait helpers out of
service_containers.go— follows #14385, which rewriteswaitDependencyReached.🤖 Generated with Claude Code