You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
perf(search): bound candidate storage for early frecency pages - #963
Keep the highest-ranked files from each chunk for small, early pages in large inventories. Count every live file and use the existing score comparison to preserve page order.
#873 builds worktree index layers on this PR’s filename ranking.
The fast path applies to inventories with at least 65,536 entries and pages ending within the first 128 results. The timings are warm medians from 15 repetitions on a 1.87-million-file repository. All pages matched the stock results, including total counts, scores and order.
Improved responsiveness when browsing large file collections with small paginated result sets. Results continue to exclude deleted files and preserve the total count of matching files.
Pagination continues to return results in frecency order across pages, including when the number of results requested is small.
Review was skipped as selected files did not have any reviewable changes.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: c9328539-c8e7-468c-9dc7-5fa78f10a9cc
Commits
Reviewing files that changed from the base of the PR and between 2fa8267 and 6814069.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
rank_by_frecency uses chunked top-candidate scoring for qualifying large, unfiltered file slices. Other cases use full frecency accumulation. Tests compare results across pages, thread counts, and current-file settings.
For qualifying slices, ranking processes chunks, skips deleted files, counts live files, and retains top candidates. Other cases use full frecency accumulation. Tests cover 132,000- and 140,000-file inputs and compare bounded results with full ranking.
dmtrKovalenko/fff#958: Adds comparator and partial top-k scoring used by this bounded ranking path.
dmtrKovalenko/fff#914: Continues layer-aware scoring and includes bounded frecency ranking.
dmtrKovalenko/fff#873: Its layered filename index score path uses the ranking implementation from this PR.
Merge Risk: Minimal · previous review 3cf35
The bounded ranking preserves the existing ordering; no material merge risk was identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: limiting candidate storage for early frecency search pages.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Repository UI
Review profile: CHILL
Plan: Advanced
Run ID: b8350941-f00c-4969-806c-940eb4ad010a
Commits
Reviewing files that changed from the base of the PR and between e6d99f5 and 3cf352e.
Files selected for processing: 1
crates/fff-core/src/score.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
Keep the highest-ranked files from each chunk for small, early pages in large inventories. Count every live file and use the existing score comparison to preserve page order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-reviewedReview completed; does not imply approval
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the highest-ranked files from each chunk for small, early pages in large inventories. Count every live file and use the existing score comparison to preserve page order.
#873 builds worktree index layers on this PR’s filename ranking.
The fast path applies to inventories with at least 65,536 entries and pages ending within the first 128 results. The timings are warm medians from 15 repetitions on a 1.87-million-file repository. All pages matched the stock results, including total counts, scores and order.
This change uses the score comparison added in #958.
Review order
Summary by CodeRabbit