Repository navigation
perf(grep): rank the first file batch before searching - #960
Merged
Merged
Conversation
Rank the first file batch before searching large candidate lists. Sort the remaining files when a search reaches them. Preserve the order of files with equal scores.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 56.25% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 4 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: ranking the first file batch before searching. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
kwojcik-blockether
added a commit
to Blockether/fff
that referenced
this pull request
Nov 4, 2026
Bring in 23 upstream commits, among them the bigram column reuse fix (dmtrKovalenko#962), literal git status paths (dmtrKovalenko#922), the faster first grep batch (dmtrKovalenko#960) and Blueprint text detection (dmtrKovalenko#931). The fork's default ripgrep walker now uses is_binary_file, so text .blp files stay searchable there too. The upstream post-scan test sets the fork's respect_ignore_files field. Vis-Session: 87db81b7-743c-4c3a-9132-78b8940cc023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rank the first file batch before searching large candidate lists. Sort the remaining files when a search reaches them. Preserve the order of files with equal scores.
Stock Criterion compared the change with #958 on a warm 1.87-million-file repository. The content index was disabled. Each value is the median of two fresh process medians.
The first page returned 53 matches and stopped after 4,090 files. Full-scan timings overlapped. The regression test compares batch order and deep cursors against a full stable sort.
Summary by CodeRabbit