feat(nextjs): add disableWatch option to skip extra env-file watching#883
Closed
mhornbacher wants to merge 1 commit into
Closed
feat(nextjs): add disableWatch option to skip extra env-file watching#883mhornbacher wants to merge 1 commit into
mhornbacher wants to merge 1 commit into
Conversation
commit: |
Plugin sets __VARLOCK_NEXT_DISABLE_WATCH; Next forwards that delta into @next/env updateInitialEnv, which unwatches already-installed extra env file watchers. No globalThis bridge. Co-authored-by: Cursor <cursoragent@cursor.com>
a381ae5 to
858e58c
Compare
Member
|
I think I solved this with a different tactic - we can just detect the FIFO and not watch it at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disableWatchtovarlockNextConfigPlugin(setsprocess.env.__VARLOCK_NEXT_DISABLE_WATCH)@next/envupdateInitialEnv, which tears down extra-file watchersnext-env-compatviaglobalThis+process.env.__VARLOCK_NEXT_WATCHED_EXTRA_FILES(loadEnvConfig and updateInitialEnv can hit different copies)Test plan
@varlock/nextjs-integrationDEBUG_VARLOCK_NEXT_INTEGRATION=1withdisableWatch: truenext-env-compat module init <id>(possibly two ids), then after plugin:updateInitialEnvwith{ instance, newEnv }anddisableWatch: unwatchAllExtraFiles { instance, count, paths }.envwatch loop stopsbun run --filter @varlock/nextjs-integration test:ci