Repository navigation
Split exact and lower-cased name lookup into two maps - #128
Merged
Merged
Conversation
Names that differ only by case shared one map, so the lower-cased entry for one constant overwrote the exact entry for another and TString() returned the wrong value. Exact names and lower-cased names now live in separate maps; exact spelling is checked first, lower-case second. Case-insensitive lookups behave as before. Regenerated code only changes result for names that collide by case. Based on #97 by gabe565. Fixes #40.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40. Based on #97 by @gabe565, rebuilt on current master.
Names that differ only by case shared one lookup map, so the lower-cased entry for one constant overwrote the exact entry for another:
Exact and lower-cased names are now in separate maps. Exact spelling is checked first, lower-case second. Case-insensitive lookups work as before; only colliding names change result.
enumer.go: one map printer called twicetestdata/casecollision.go: end-to-end regression test, fails on master