Skip to content

Add CLI classpath options - #184

Merged
dlunch merged 5 commits into
mainfrom
agent/cli-classpath
Jul 19, 2026
Merged

dlunch merged 5 commits into
mainfrom
agent/cli-classpath

Conversation

@dlunch

@dlunch dlunch commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • add -cp and -classpath launcher options with CLASSPATH and current-directory fallback
  • match Oracle launcher argument boundaries and ignore user classpath in CLI -jar mode
  • preserve the public run API classpath behavior and built-in runtime priority
  • make URLClassLoader recognize directory entries without trailing slashes and continue past missing entries

Validation

  • cargo test --workspace --quiet (246 passed, 1 ignored)
  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • git diff --check

Notes

The local environment does not contain an Oracle rt.jar, so the external JRE smoke test was not run. The same directory and JAR lookup paths are covered with repository fixtures and actual CLI process tests.

Copilot AI review requested due to automatic review settings July 19, 2026 01:32
@codecov

codecov Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.21875% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.89%. Comparing base (fd629c7) to head (230b36c).

Files with missing lines Patch % Lines
java_runtime/src/classes/java/lang/class_loader.rs 95.83% 1 Missing ⚠️
...classes/org/rustjava/lang/rust_jar_class_loader.rs 97.91% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   86.50%   86.89%   +0.38%     
==========================================
  Files         207      208       +1     
  Lines       20224    20420     +196     
==========================================
+ Hits        17495    17744     +249     
+ Misses       2729     2676      -53     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Java-launcher-compatible classpath handling to the rust_java CLI, aligning option parsing with the Oracle launcher while preserving the existing run API behavior. It also improves URLClassLoader resource lookup semantics around directory entries and missing URLs.

Changes:

  • Add -cp / -classpath support with CLASSPATH and current-directory fallback, and ignore user classpath in CLI -jar mode.
  • Refactor classpath property construction into a dedicated helper and add unit/integration coverage for launcher parsing/behavior.
  • Update URLClassLoader to treat directory URLs without trailing slashes as directories and to continue searching after missing entries.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/test_cli.rs Adds end-to-end CLI tests for classpath options, env fallback, -jar behavior, and error reporting.
src/main.rs Implements launcher-style argument parsing (-cp/-classpath/-jar) and wires computed classpath into run.
src/lib.rs Extracts classpath property construction into build_class_path and adds unit tests for ordering/empty entries.
java_runtime/tests/classes/java/net/test_url_class_loader.rs Adds regression test ensuring missing URL entries don’t prevent later JAR resource lookup.
java_runtime/src/classes/java/net/url_class_loader.rs Updates URLClassLoader::findResource directory/jar detection and missing-entry behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib.rs Outdated
Comment thread tests/test_cli.rs
Comment thread src/main.rs
Comment thread src/main.rs Outdated
Comment thread src/main.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 589f73522d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/lib.rs Outdated
Comment thread src/lib.rs Outdated
Comment thread src/main.rs Outdated
Comment thread src/main.rs
@dlunch
dlunch merged commit 3296139 into main Jul 19, 2026
10 checks passed
@dlunch
dlunch deleted the agent/cli-classpath branch July 19, 2026 04:07
Jun025 added a commit to Jun025/RustJava that referenced this pull request Aug 27, 2026
* Bump bytemuck from 1.25.0 to 1.25.1 (dlunch#173)

Bumps [bytemuck](https://github.com/Lokathor/bytemuck) from 1.25.0 to 1.25.1.
- [Changelog](https://github.com/Lokathor/bytemuck/blob/main/changelog.md)
- [Commits](Lokathor/bytemuck@v1.25.0...v1.25.1)

---
updated-dependencies:
- dependency-name: bytemuck
  dependency-version: 1.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Replace runtime panics with the matching Java exceptions (dlunch#174)

* Replace runtime panics with the matching Java exceptions

An unwrap audit found panics reachable from ordinary Java code:

- File.length() returns 0 for a missing file; isDirectory/isFile lose
  their guard-then-unwrap shape
- FileImpl (native runtime) maps open/read/write/seek failures to
  IOError instead of panicking, so FileInputStream and RandomAccessFile
  guards actually produce FileNotFoundException; FileOutputStream gains
  the same guard
- File I/O operations (read/write/seek/available/length/setLength)
  throw java.io.IOException on failure via a shared helper
- Class.forName resolves the class and throws ClassNotFoundException
  (new runtime class) instead of panicking on any not-yet-loaded name
- StringBuffer.append(char)/append(char[]) keep exact UTF-16 units so
  unpaired surrogates no longer panic and pairs built char by char
  survive; String.valueOf(char) builds through [C for the same reason
- PrintStream.println(char) replaces an unpaired surrogate with '?'
  like the JDK charset encoder
- ZipFile validates the archive in its constructor and throws
  java.util.zip.ZipException (new runtime class) for a malformed
  archive; getInputStream returns null for a missing entry

Expected outputs for the new fixtures are generated by a real JVM.
Remaining unwraps are invariants (interpreter stack discipline, thread
attach), guarded lookups, or documented gaps (lenient calendar
normalization, ClassFormatError plumbing).

* Inline the IOException conversion at each I/O call site

* Return the same Thread object from Thread.currentThread() (dlunch#175)

Every attached thread now owns its java/lang/Thread instance: attach
takes the instance for threads started via Thread.start (so
currentThread() inside run() is the started Thread object) and creates
one otherwise (bootstrap, external attachers). currentThread() returns
the stored instance, and the GC roots it per thread.

Also parse unrecognized classfile attributes as an opaque Unknown
variant instead of failing — JVMS 4.7.1 requires silently ignoring
them, and the anonymous-class fixture carries EnclosingMethod and
Signature attributes the parser rejected.

Expected output for the fixture is generated by a real JVM.

* Add Java primitive wrapper classes (dlunch#176)

* Add Java primitive wrapper classes

* Use Character digit semantics for numeric parsing

* Bump tokio from 1.52.3 to 1.52.4 (dlunch#179)

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.52.3 to 1.52.4.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.52.3...tokio-1.52.4)

---
updated-dependencies:
- dependency-name: tokio
  dependency-version: 1.52.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add CLDC 1.1 core API compatibility (dlunch#177)

* Add CLDC 1.1 core API compatibility

* Fix CI lint and improve CLDC coverage

* Fix array assignability and reader progress

* Harden JVM runtime correctness (dlunch#180)

* Harden JVM runtime correctness

* Address classfile review findings

* Move class initialization tests to Java fixture

* Separate classfile validation from JVM verification

* Remove ClassFileError re-export

* Bump tokio from 1.52.4 to 1.53.0 (dlunch#181)

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.52.4 to 1.53.0.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.52.4...tokio-1.53.0)

---
updated-dependencies:
- dependency-name: tokio
  dependency-version: 1.53.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Hide classfile errors behind class definition errors

* Delegate null-parent class loading to bootstrap

* Remove duplicate array instance methods

* Add JNI-style global references (dlunch#182)

* Generalize monitor instance arguments

* Add CDC text formatting APIs (dlunch#183)

* Add CDC text formatting APIs

* Add integer number format factories

* Fix text format position handling

* Add CLI classpath options (dlunch#184)

* Add CLI classpath options

* Simplify URL classpath lookup

* Fix platform classpath handling

* Use File path separator for class loading

* Separate RustJar class loading

* [rustjava-upstream-sync-s4] test: widen test_timer_periodic margin 500ms->2000ms (upstream 3296139 slowed TimerThread)

* [rustjava-upstream-sync-s4] docs: record S4 landing (cut 3296139, conflicts 20->2) + S3 landing sha

* [rustjava-upstream-sync-s4] docs: correct the timer finding - chronic boundary test, not a cut regression

The prior wording compared a standalone run on origin/main against parallel full-suite runs on
upstream and called the gap a regression. Matched-condition alternating runs show no difference
(standalone x10: pre 3.5 mean / post 3.5 mean; full-suite x8: no difference). Upstream widened
this same margin in 895d67d (2025-08) and ad8b477 (2025-10), both already ancestors of main,
11 months before e557673 (2026-07) which the prior wording blamed.

sleep 2000 and both conflict resolutions are untouched. Comment-only in .rs; no code change.

* [rustjava-upstream-sync-s4] docs: retarget follow-up (4) - no timer perf regression exists; the open axis is our test's wall-clock dependence

REPORT.md line 27 already said the 'imported upstream regression' framing was wrong, but the
follow-up list 20 lines below still carried it verbatim - and that list is what the next round
tickets from. Retargeted to the axis that does exist (our test design, no upstream sending).

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Inseok Lee <git@dlun.ch>
Co-authored-by: jun0 <junyoung.choi.a@miraeasset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants