Fake PR to test the upstreaming of commit up to gerris/rebase-upstream/2026-08-16 - #116
Open
dkm wants to merge 4 commits into
Open
Fake PR to test the upstreaming of commit up to gerris/rebase-upstream/2026-08-16#116dkm wants to merge 4 commits into
dkm wants to merge 4 commits into
Conversation
Makes ExpandVisitor rely more on functions provided by PointerVisitor. More can be done in this area, but this is enough for now to fix an issue compiling core. gcc/rust/ChangeLog: * expand/rust-expand-visitor.cc (ExpandVisitor::expand_struct_fields): Remove function definition. (ExpandVisitor::expand_tuple_fields): Likewise. (ExpandVisitor::visit (Function)): Visit outer attributes, add comment about inner attribute visiting. (ExpandVisitor::visit (StructStruct)): Remove function definition. (ExpandVisitor::visit (TupleStruct)): Likewise. (ExpandVisitor::visit (EnumItemTuple)): Likewise. (ExpandVisitor::visit (EnumItemStruct)): Likewise. (ExpandVisitor::visit (Union)): Likewise. (ExpandVisitor::visit (ExternalStaticItem)): Likewise. * expand/rust-expand-visitor.h (ExpandVisitor::visit (StructStruct)): Remove function declaration. (ExpandVisitor::visit (TupleStruct)): Likewise. (ExpandVisitor::visit (EnumItemTuple)): Likewise. (ExpandVisitor::visit (EnumItemStruct)): Likewise. (ExpandVisitor::visit (Union)): Likewise. (ExpandVisitor::visit (ExternalStaticItem)): Likewise. (ExpandVisitor::expand_fields): Likewise. gcc/testsuite/ChangeLog: * rust/compile/doc_macro_2.rs: New test. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
Warn on a double arithmetic negation such as `- -x`, which is likely a mistake (Rust has no `--` operator). gcc/rust/ChangeLog: * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): New. * checks/lints/unused/rust-unused-checker.h (UnusedChecker::visit): New. gcc/testsuite/ChangeLog: * rust/compile/double-negations_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
When creating the list of generic types for the derived impl, default parameters should be skipped as they can only be present on type definitions, not impls. gcc/rust/ChangeLog: * ast/rust-ast-builder.h: Add new parameter to Builder::new_type_param to avoid recreating default type parameters when building the new type parameter. * ast/rust-ast-builder.cc: Implement the change. * expand/rust-derive.cc: Use it in setup_impl_generics. gcc/testsuite/ChangeLog: * rust/compile/derive-with-default-types.rs: New test.
This is only bringing basic CI. Never push upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fake PR, not meant to be merged.
It tries to merge commits to upstream with an upstream base branch dkm/upstream-base.
We're only interested by the CI results. The branch to push is in {new_branch}.
-- gerris 🦀