Repository navigation
Use dit's rng keyword for surrogates and Markov-order selection - #14
Merged
Merged
Conversation
dit #306 renamed prng to rng; the old name still works through a deprecation alias that warns and will be removed in dit 3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dit #306 renamed
prngtorngacross dit. infoflow still passedprng=towhittle_surrogates,shift_surrogates,block_surrogatesandselect_markov_orderininfoflow/te.py. Those calls work through dit's deprecation alias, which warns on every call and will be removed in dit 3.0. This switches them torng=.total_correlation_ksgalready moved torng=in #12, and the upstream alias fix (dit/dit#324) is closed. No other infoflow call passes a deprecated keyword to dit.Checked:
transfer_entropy_testwith the whittle, shift and block nulls, plustransfer_entropy(history_length="auto"), with the deprecation turned into an error: the previous code raises, this one doesn't.tyandruffare clean.Made with Cursor