Repository navigation
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…e changes (react#59101) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports react/react-native#59101 behind a new
discordSkipUnchangedYogaDirtyfeature flag (defaultfalse). With the flag on,YogaLayoutableShadowNode::setSizeandsetPositionTypereturn early when the value is unchanged, instead of dirtying the Yoga node on every clone (component descriptors call these fromadopt), which otherwise forces a layout pass over the whole tree on each commit.The flag follows the same shape as
discordUiManagerOptimization, so the app can drive it from per-platform experiments.Test steps
YogaDirtyFlagTestcases inViewTest.cpp(settingUnchangedSizeMustNotDirtyYogaNode,settingUnchangedPositionTypeMustNotDirtyYogaNode) override the flag totrueand assert that re-setting the same size or position type doesn't dirty the tree.false), behavior is unchanged.Note
These gtests are BUCK-only upstream and aren't run by this repo's GitHub workflows, so they weren't executed here. Validation happens in the Discord app via the experiment.