Skip to content

[discord] UIManagerConstantsCache - build the constants native map on first request #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joemun merged 2 commits into from
Sep 18, 2026
Merged

[discord] UIManagerConstantsCache - build the constants native map on first request #53

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508bc84
[Discord] Build the constants native map on first request
joemun Sep 17, 2026
eda0428
Drop the conversion guard
joemun Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions ...tive/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerConstantsCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
* On init(...), a background thread:
* 1) calls MMKV.initialize(...)
* 2) reads both keys, parses them into Maps
* 3) builds a WritableNativeMap from the full constants map via Arguments.makeNativeMap(...)
* 4) countDown()s loadLatch
* 3) countDown()s loadLatch
*
* Exposed methods all block until that single background load finishes:
* • getCachedConstants() → Map<String,Object> or null
Expand Down Expand Up @@ -80,8 +79,7 @@ public static UIManagerConstantsCache getInstance() {
* constants are accessed. This kicks off:
* 1) MMKV.initialize(...)
* 2) A background thread that reads two MMKV keys, parses them → Maps,
* then builds a WritableNativeMap from the full constants, and finally
* countDown()s loadLatch.
* and countDown()s loadLatch.
*/
public synchronized void init(Context appContext) {
if (initCalled) {
Expand Down Expand Up @@ -173,15 +171,6 @@ public synchronized void init(Context appContext) {
}
Log.v(TAG, "No bubblingEventTypes found in MMKV.");
}

// 2c) Build WritableNativeMap from full constants (if available)
synchronized (this) {
if (cachedConstants != null) {
cachedNativeMap = Arguments.makeNativeMap(cachedConstants);
} else {
cachedNativeMap = null;
}
}
} finally {
// Signal load completion
loadLatch.countDown();
Expand Down Expand Up @@ -224,8 +213,14 @@ public Map<String,Object> getCachedBubblingEventsTypes() {
}

/**
* Blocks until background-load (and WritableNativeMap build) finishes.
* @return pre-built WritableNativeMap or null if no full-constants available.
* Blocks until the background load finishes, then returns the full constants as a
* WritableNativeMap, building it on the first call.
*
* The map is built here rather than on the loading thread because constructing a
* WritableNativeMap loads React Native's native library, which callers of this method
* already require.
*
* @return WritableNativeMap or null if no full-constants available.
*/
public WritableNativeMap getUIManagerConstantsAsWritableMap() {
try {
Expand All @@ -236,6 +231,9 @@ public WritableNativeMap getUIManagerConstantsAsWritableMap() {
return null;
}
synchronized (this) {
if (cachedNativeMap == null && cachedConstants != null) {
cachedNativeMap = Arguments.makeNativeMap(cachedConstants);
}
return cachedNativeMap;
}
}
Expand Down