Skip to content

feat(http)!: carry the management listener's keys in the flat OperationsConfig - #370

Merged
patdowney merged 1 commit into
masterfrom
feat/operations-config-management-keys
Nov 15, 2026
Merged

patdowney merged 1 commit into
masterfrom
feat/operations-config-management-keys

Conversation

@patdowney

Copy link
Copy Markdown
Contributor

Summary

  • Add management-enable-proxy-protocol, management-tls-server and enable-prometheus-metrics (on unless set false) to OperationsConfig, so one flat, prefixed form carries every management-listener key. Operational() now carries the PROXY protocol and metrics settings.
  • Check accepts a non-loopback listener when management-tls-server requires client certificates (RequireAndVerifyClientCert with a client-ca-file), validates the TLS block, and its finding names the new option.
  • Breaking: remove the nested ManagementConfig added in v0.75.0. connect-control, edgerouter and eventbroker already use the flat prefixed keys, so connect and the eventbroker adopt this form instead of a second one (dioad/connect#559, dioad/eventbroker#108).
  • Fix the long-standing QF1002 finding on master while rewriting that function: make lint is clean.

Test plan

  • go test -race ./..., make lint
  • Client-certificate exemption, the not-verified-against-a-CA case, the PROXY protocol and metrics toggles in Operational()

Migration

ManagementConfig users move to OperationsConfig: management-listen-address, management-allow-unauthenticated-non-loopback, management-enable-proxy-protocol, management-tls-server, enable-debug, shutdown-drain-delay.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ

…onsConfig

Add management-enable-proxy-protocol, management-tls-server and
enable-prometheus-metrics (on unless set false) to OperationsConfig, and let
Check accept a non-loopback listener whose management-tls-server requires
client certificates. Operational now carries the PROXY protocol and metrics
settings.

Remove the nested ManagementConfig added in v0.75.0: services share one form
of these keys, the flat prefixed one most already use.

BREAKING CHANGE: ManagementConfig is removed. Use OperationsConfig, whose keys
are management-listen-address, management-allow-unauthenticated-non-loopback,
management-enable-proxy-protocol, management-tls-server and enable-debug.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ
@patdowney
patdowney merged commit 4fd959d into master Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant