Repository navigation
feat(http)!: carry the management listener's keys in the flat OperationsConfig - #370
Merged
Merged
Conversation
…onsConfig Add management-enable-proxy-protocol, management-tls-server and enable-prometheus-metrics (on unless set false) to OperationsConfig, and let Check accept a non-loopback listener whose management-tls-server requires client certificates. Operational now carries the PROXY protocol and metrics settings. Remove the nested ManagementConfig added in v0.75.0: services share one form of these keys, the flat prefixed one most already use. BREAKING CHANGE: ManagementConfig is removed. Use OperationsConfig, whose keys are management-listen-address, management-allow-unauthenticated-non-loopback, management-enable-proxy-protocol, management-tls-server and enable-debug. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
management-enable-proxy-protocol,management-tls-serverandenable-prometheus-metrics(on unless set false) toOperationsConfig, so one flat, prefixed form carries every management-listener key.Operational()now carries the PROXY protocol and metrics settings.Checkaccepts a non-loopback listener whenmanagement-tls-serverrequires client certificates (RequireAndVerifyClientCertwith aclient-ca-file), validates the TLS block, and its finding names the new option.ManagementConfigadded in v0.75.0. connect-control, edgerouter and eventbroker already use the flat prefixed keys, so connect and the eventbroker adopt this form instead of a second one (dioad/connect#559, dioad/eventbroker#108).QF1002finding onmasterwhile rewriting that function:make lintis clean.Test plan
go test -race ./...,make lintOperational()Migration
ManagementConfigusers move toOperationsConfig:management-listen-address,management-allow-unauthenticated-non-loopback,management-enable-proxy-protocol,management-tls-server,enable-debug,shutdown-drain-delay.🤖 Generated with Claude Code
https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ