Skip to content

feat(http): add ManagementConfig, a nested management listener block - #365

Merged
patdowney merged 1 commit into
masterfrom
feat/operations-config-keys
Nov 15, 2026
Merged

patdowney merged 1 commit into
masterfrom
feat/operations-config-keys

Conversation

@patdowney

Copy link
Copy Markdown
Contributor

Summary

  • Add http.ManagementConfig: a nested block (listen-address, allow-unauthenticated-non-loopback, enable-prometheus-metrics, enable-debug, enable-proxy-protocol, tls-server) with Check and Operational().
  • Check accepts a non-loopback listener without the acknowledgement when tls-server requires client certificates, as connect does today.
  • Add tls.ServerConfig.RequiresClientCertificate for that test, and a constant for the repeated RequireAndVerifyClientCert string.
  • OperationsConfig (the flat form) is unchanged, so existing users are not affected.

Lets connect (and eventbroker) adopt one shared management block (dioad/connect#559, Q2 and Q3).

Test plan

  • go test -race ./...
  • go vet ./...
  • New lint findings fixed. make lint still reports http/operations.go:49 (QF1002), which exists on master.

🤖 Generated with Claude Code

https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ

ManagementConfig carries listen-address, the non-loopback acknowledgement,
metrics, debug, PROXY protocol and tls-server under one block, with a Check
that accepts a non-loopback listener when tls-server requires client
certificates. Add tls.ServerConfig.RequiresClientCertificate for that test.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ
@patdowney
patdowney merged commit 9049c25 into master Nov 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant