Repository navigation
feat: add App.Ready so an App is a health source on its own - #3
Merged
Merged
Conversation
App already had Live; with Ready it satisfies both of dioad/net's health interfaces and can be passed to AddHealthSource as one value. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App.Ready, which delegates toReadiness().Ready.Appalready hasLive; withReadyit satisfies bothdioad/nethealth interfaces (LivenessResource,ReadinessResource), so it can be passed toServer.AddHealthSourceorWithReadinessas one value.This lets connect drop its
serviceHealthwrapper (dioad/connect#559, Q4).Test plan
make verifyTestApp_IsAHealthSourceOnItsOwnasserts the interface and thatReadyandLivebehave🤖 Generated with Claude Code
https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ