Skip to content

feat(configcheck): add Collector.Inert for settings that have no effect - #3

Merged
patdowney merged 1 commit into
mainfrom
feat/collector-inert
Nov 15, 2026
Merged

patdowney merged 1 commit into
mainfrom
feat/collector-inert

Conversation

@patdowney

Copy link
Copy Markdown
Contributor

Summary

  • Collector.Inert(names...) reports each populated-but-inert setting as a finding at the collector's path, so a command rejects it with its other findings.
  • The commit also carries the go.mod/go.sum bumps that were already staged in the working tree (go 1.26.0, generics).

Part of connect-control's shared-helpers plan (step 2, doc/proposals/shared-server-helpers.md), so services stop keeping their own RejectInert.

Test plan

  • go vet ./..., go test -race ./...

🤖 Generated with Claude Code

https://claude.ai/code/session_01SS4MAvnUSKyK9WP4pSz5Gg

A setting that is populated but does nothing leaves an operator believing it
applies. Inert reports each such setting as a finding at the collector's path,
so a command rejects it alongside its other findings.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SS4MAvnUSKyK9WP4pSz5Gg
@patdowney
patdowney merged commit 71298e6 into main Nov 15, 2026
4 checks passed
@patdowney
patdowney deleted the feat/collector-inert branch November 15, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant