Repository navigation
feat(server): add WithPrincipalACL and allow APIMiddlewares without an extractor - #150
Merged
Merged
Conversation
…n extractor APIOption lets APIMiddlewares take WithPrincipalACL next to the existing ValidatorHandlerOptions, which remain valid options, so current callers are unchanged. A nil extractor leaves principal extraction out, for an API that authorises by who the caller is rather than by role. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APIMiddlewaresnow takes...APIOption.ValidatorHandlerOptionimplements it, so existing callers (connect-control, server-example) compile unchanged.WithPrincipalACL(acl)appends the principal allow/deny ACL after validation and extraction, for APIs that authorise by who the caller is rather than by role.Lets connect's mail management routes use the shared chain instead of a local copy (dioad/connect#559, C9). CORS stays ahead of the chain and is covered separately in dioad/net.
Test plan
make verify🤖 Generated with Claude Code
https://claude.ai/code/session_01SS4MAwAn85D1gkEzLtjYaZ