Skip to content

oidc.ValidatorConfig config keys are snake_case, not kebab-case #147

Open

Description

@patdowney

oidc.ValidatorConfig names its config keys in snake_case, where every other Dioad config key is kebab-case:

cache_ttl_seconds, signature_algorithm, signature_algorithms, allowed_clock_skew_seconds, claim_predicates, hmac_secret, allow_insecure_hmac.

configwalk.KeyNamingProblems in dioad/config v0.2.0 reports each of them ("is not kebab-case"). connect's cmd/config_naming_test.go lists them as exceptions until this is fixed.

Renaming a key breaks every config that sets it, so it needs a deprecation path: accept the kebab-case key (cache-ttl-seconds, claim-predicates, ...) and keep reading the old one with a warning for a release or two, then drop it.

Found while moving connect's naming test onto configwalk.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions