fix(ci): match the canary package to its cached crate name - #53
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canary stores one artifact, but kache 0.28.1 sync compares Cargo package names literally against rustc crate names. The private fixture name used hyphens while its cache identity used underscores, so workspace-scoped push selected no artifacts. Use an underscore package name in the unpublished fixture and lockfile. Keep the scoped upload and fresh-runner reuse assertions intact.
Evidence: tagged upstream src/cli.rs get_workspace_crate_names and sync_with_client; failed main run36820883995 recorded one stored entry and zero upload candidates. Validation: cargo metadata --locked, focused workflow contract tests, diff check.