fix: harden ingestion, recovery, and review qualification - #244
Merged
Conversation
`Docs Contract` fails on main: tests/live/generate-docs.py --check reports the TEST_COVERAGE.md live inventory is stale. #222 added test files without regenerating it. Regenerated with the repository's own generator; --check now passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ediation # Conflicts: # docs/runbooks/deploy.md # tests/live/phases/mutation/selftest.sh # tests/live/surface-exporter/Cargo.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cortex could lose or misrepresent ingestion evidence, release query capacity while cancelled database work was still running, and overwrite existing backup destinations. This PR addresses 48 repository-review findings and the additional issues found during Lavra and Vibin review, including pre-existing defects and stale CI contracts.
The changes bound ingestion and query memory, preserve file rotation and checkpoint recovery, make durable journal replay deterministic, keep source paths out of journal files, and report oversized records explicitly. Backup destinations must be new files; restores stage and validate all components before promotion. Authentication, graph redaction, subprocess ownership, transcript backfills, and browser request ordering are also corrected.
Qualification now attributes each mutation to a passing baseline and a specific failing behavioral test, isolates Cargo output, and terminates detached processes on cancellation. The branch incorporates main 3.16.2, updates release qualification pins and deprecated action runtimes, synchronizes packaged documentation, and brings standalone fixtures into the lint contract.
Validation:
No production deployment or Windows runtime execution was performed. Windows platform code was cross-compiled for metadata validation. Review coverage is bounded to the PR and traced surrounding code.