Repository navigation
Conversation
Use the committed fixture filename and its first records entry so the non-plain-bundle guard is exercised. Signed-off-by: Srinivasa Dinakar Jainti <dinakarjs@gmail.com> Signed-off-by: Srinivasa Consultants <78673153+dinakarjs@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream agentrust-io#622's new non-plain-bundle test reads a nonexistent vector filename and accesses
vec.record, while the committed vector exposesrecords. This two-line test correction uses20-malformed-statement-on-another-log.jsonandvec.records[0], so the test reaches the intended verifier boundary. Runtime source and normative text are unchanged.Based directly on upstream c94f4f9; preserve the original author's history when adopting. Addresses lywinged's current review: agentrust-io#622 (review) .
Validation:
npm ci --ignore-scripts --no-audit --no-fund, thennpm teston Node 24.22.1. Before: 164 passed, one failed on the missing fixture. After: 165 passed, zero skipped. Removing only thecheckRevocationBundleplain-object guard causes the repaired case to fail withinvalid_argument; restoring it returns all 165 to passing. Diff whitespace passes. The published tree f76a4e43a6fcd3c223ec48aafe8e71151c6fb974 matches the tested tree.Node 20/22, the full Python suite and differential workflow were not rerun for this two-line test-only companion. No separate fresh-reader session was performed; author adoption and independent review remain. No new rejection or normative rule is introduced; no changelog entry proposed. Prepared with OpenAI Codex; DCO sign-offs included.