Repository navigation
Conversation
Signed-off-by: Srinivasa Dinakar Jainti <dinakarjs@gmail.com>
4 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author-adoption companion to agentrust-io#588 at 547a4ef. Implements lywinged's requested ASCII guard before str compare_digest, preserving DelegationError and existing valid SHA256/SHA384 links. No change to the draft chain walk or its rule independence.
Python 3.12.14, existing development environment: 160 delegation module/vector/completeness tests pass; targeted Ruff, mypy and whitespace checks pass. Four new cases (non-ASCII and lone surrogate, SHA256 and SHA384) fail with TypeError on the unmodified parent and pass with the guard. A near-miss encoding both operands as UTF-8 passes the non-ASCII cases but fails both surrogate cases. Final source restored and tests rerun.
This is a one-commit companion for the original author to cherry-pick, not independent approval or an upstream replacement. Nonblocking trusted-key typing, draft-profile wording and changelog feedback remain for the author's disposition. No new cold-reader review is claimed; hosted checks and maintainer re-review remain required. Prepared with Codex.
Signed-off-by: Srinivasa Dinakar Jainti dinakarjs@gmail.com