Repository navigation
Conversation
Signed-off-by: Srinivasa Consultants <78673153+dinakarjs@users.noreply.github.com>
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The collector experiment counts rows but cannot detect altered event bodies or lost projection fields. Add a three-event usage fixture with complete body, timestamp, event-name and attribute comparisons, separate order measurement, and missing/duplicate/foreign-event checks. Correct the experiment's TypeScript emitter to carry nanosecond timestamps and attributes; SDK runtime code is unchanged.
Stacked follow-up to agentrust-io#100, based on 2714186. This fork PR isolates the follow-up until its parent lands; retarget/rebase afterward. The queue companion changes the same experiment workflow and will need reconciliation when both are adopted.
Validation: four unittest methods pass, including real Python and TypeScript SDK emitters over loopback HTTP plus corruption controls. Reverting only the TS emitter to the parent version makes the new real-emitter test fail. TypeScript build, Node syntax, Python compilation, focused Ruff and actionlint pass. A Collector attempt hit the sandbox process-metrics startup error before delivery; the new full Collector fidelity case remains a hosted-CI gate. The parent's twelve passing cases do not validate this change.
Scope is the usage fixture and its six projected attributes, not exhaustive event-type fidelity, trace context or production delivery. Draft; no conformance tier change. AI-assisted with Codex; DCO signed.