Improve BevyLinesRenderBackend performance - #700
Open
IceSentry wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The drawing enabled check is currently done just before drawing a line, but the filter_object can return much earlier than that. I have a scene with thousands of complex collider that were using
ColliderDebug::NeverRenderbut the debug renderer still had to go through each edges of each of those objects before returning. With this change it now filters early any entities that have drawing disabled. In my scene I went from 15fps back to vsync.I also noticed that drawing a polyline would query for the object color for every line segment. So instead of using the default implementation I overloaded it to get the color once per object and draw the lines directly. In my scene, when not filtering any colliders I went from 15fps to 20fps. It's pretty minor, but there's a lot of overhead in multiple places and this one was pretty low impact to do. I've been looking into the debug renderer and I have ideas on how to make it perform better when rendering a lot of complex colliders but this will take multiple more complex PRs.