fix order of _disposables

Author: jeff-hykin

dimos/agents/mcp/mcp_server.py

@@ -180,7 +180,6 @@ def start(self) -> None:
     def stop(self) -> None:
         if self._uvicorn_server:
             self._uvicorn_server.should_exit = True
-            loop = self._async_thread.loop
             if self._serve_future is not None:
                 self._serve_future.result(timeout=5.0)
             self._uvicorn_server = None

dimos/core/module.py

@@ -134,15 +134,17 @@ def _stop(self) -> None:
                 return
             self.mod_state.set("stopped")
 
+        # dispose of things BEFORE making aspects like rpc and _tf invalid
+        if hasattr(self, "_disposables"):
+            self._disposables.dispose()  # stops _async_thread via disposable
+
         if self.rpc:
             self.rpc.stop()  # type: ignore[attr-defined]
             self.rpc = None  # type: ignore[assignment]
 
         if hasattr(self, "_tf") and self._tf is not None:
             self._tf.stop()
             self._tf = None
-        if hasattr(self, "_disposables"):
-            self._disposables.dispose()  # stops _async_thread via disposable
 
         # Break the In/Out -> owner -> self reference cycle so the instance
         # can be freed by refcount instead of waiting for GC.