fix(views): acknowledge note modal ephemerally to prevent duplicate thread activity - #49
Merged
Merged
Conversation
…hread activity Respond ephemerally with auto-dismissal toast upon submitting TaskNoteModal, ensuring the transactional Outbox pipeline remains the single source of truth for public thread activity logs and watcher dispatch. Closes #48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate note activity messages in Task Thread Workspaces by acknowledging
TaskNoteModalsubmissions with an auto-dismissing ephemeral toast, leaving the asynchronous Outbox worker as the single source of truth for public thread activity logs and watcher dispatch.Closes #48
Root Cause
Previously,
TaskNoteModal.on_submitreplied to the modal interaction withephemeral=False, sending a public message directly into the task thread. Concurrently,task_service.add_noteproduced aNOTE_ADDEDtransactional outbox event, which the outbox worker dispatched viaDiscordNotifier._handle_note_added(workspace.post_activity), resulting in two public messages with identical note contents in the thread.Changes
TaskNoteModal.on_submitinsrc/adapters/discord_bot/views/task_modals.pyto reply withephemeral=Trueand schedule toast dismissal viamenu_manager.schedule_toast_dismissal.tests/test_discord_thread_lifecycle.pyverifying ephemeral acknowledgment and toast scheduling.Verification
make checkpassing (lint, format, and 394 tests passed).make docker-build.