fix(bot): prevent duplicate persistent error notifications on command check failures - #47
Merged
Merged
Conversation
… check failures Guard DggPmBot.on_tree_error against re-dispatching when commands have error handlers, pass wait=True to interaction.followup.send to ensure dismissal targeting, and add regression tests. Closes #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where users without required command permissions received two simultaneous error notifications—one temporary auto-dismissing toast and one persistent followup notification that remained on screen indefinitely.
Closes #46
Summary of Changes
DggPmBot.on_tree_error(bot.py):command._has_any_error_handlers()to suppress duplicate dispatch if a cog or command-level error handler (cog_app_command_error) already handled the error.wait=Truetointeraction.followup.send(..., wait=True)so discord.py returns theWebhookMessageinstead ofNone.menu_manager.schedule_toast_dismissal, allowing ephemeral followup errors to be cleanly auto-dismissed.wait=Trueand scheduled for dismissal.Verification
make check(397 tests passing, ruff lint and format check clean).