Repository navigation
Correct stale comments in the iframe proxy, browser hosts, relay and pairing tests, and docs parser - #1392
Conversation
…pairing tests, and docs parser - iframe-proxy.ts: drop comparisons to the removed stream relay and point two spec references at the dor-browser.md headings that hold the rules. - browser-host.ts: own() lives in remote-control-shared.ts. - agent-browser-host.ts: drop a capture-timeout comment stranded above the stream-port constants. - Undo Host->Burrow rename damage where "host" meant a network host. - static.test.mjs: the built-shell script check is assert-pocket-worker.mjs. - github-state-check.test.mjs: name the formats, not the PRs. - docs-parser.js: move the Slugger banner onto slugify. - pixels.ts: describe the tie-break dominantBorderColor actually makes.
Deploying mouseterm with
|
| Latest commit: |
622fda5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dc5a0193.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-stale-comments-oct27.mouseterm.pages.dev |
|
The red |
dormouse-bot
left a comment
dormouse-bot
left a comment
There was a problem hiding this comment.
Build & Test is red on this head, but not because of this PR. It fails standalone/sidecar bash: E is the whole submitted line, and never a stale history entry with bash reported ["__systemd_osc_context_precmdline"] for "true" (job). This PR touches no shell-integration code. That's the ubuntu-26.04 runner's systemd PROMPT_COMMAND array that #1391 fixes. Once #1391 lands, a re-run should go green.
Comment and test-name corrections from tonight's rolling survey. Behavior is unchanged: apart from one local variable renamed in a test helper, every edit is a comment or a test title.
lib/src/host/iframe-proxy.ts: the header andhandleUpgradecompared the proxy to the "agent-browser stream relay". 1faca60 removed that relay, and its replacement, the viewer socket, is not a byte pipe. Those comparisons are gone, along with "notes vs the spec's sketch". Two pointers tospec → Target policyandspec → Security, headingsdor-browser.mdno longer has, now name the sections that hold the rules: "Iframe Renderer" (the https and link-local refusals) and "Iframe Host Capability And CSP" (the user's own target is trusted).lib/src/host/browser-host.ts:own()is defined inlib/src/components/remote-control-shared.ts, notRemoteControlSection.tsx.lib/src/host/agent-browser-host.ts: a capture-timeout comment sat above the stream-port retry constants. The doc comment onCAPTURE_TIMEOUT_MSinbrowser-capture.tsalready covers the capture timeout, so this one is dropped.pairing-invitation.test.mjs("By burrow, never by suffix", and theburrowlength variable inoriginOfLength), and theconnect-srctest title and comment inrelay/test/static.test.mjs.relay/test/static.test.mjs: thescript-srccomment pointed at a "built-output case below" that doesn't exist.lib/scripts/assert-pocket-worker.mjsmakes that check at build time, as the file's closing comment already says.scripts/github-state-check.test.mjs: "the two PRs' formats" now names the two formats, this script's fragment andsecurity-audit-report.mjs's parser.website/scripts/docs-parser.js: the "Slugger" banner moves from above the URL-scheme helpers to aboveslugify.dor-tools-builtin/viewer/image/pixels.ts:dominantBorderColorsaid "ties go to the first in row order", but it updates the leader only on a strictly higher count, during the scan. For a ring of A, B, B, A, B wins. The comment now describes that. Changing the tie-break itself would change whateraseSelectionfills, so it is not done here.No regression test: there is no behavior change to pin. Locally,
remote-lib-common(355) andrelay(300) pass, as dodocs-parser.test.js(47) andscripts/github-state-check.test.mjs.