Repository navigation
Correct stale spec pointers and comments in the iframe panel, browser URL helpers, and lint scripts - #1382
Merged
Conversation
… URL helpers, and lint scripts
Deploying mouseterm with
|
| Latest commit: |
cb3319e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5038eccf.mouseterm.pages.dev |
| Branch Preview URL: | https://nightly-stale-pointers-oct26.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven comments pointed at spec text that has moved or never existed, or described code that has since grown. This PR changes only comments, plus one line of a self-test's failure message, and changes no behavior. Found in the nightly survey.
lib/src/components/wall/IframePanel.tsx: the sandbox comment citeddor-browser.md→ "Iframe Renderer" for omittingallow-top-navigation. That rule is nowS138underdocs/specs/security-local.md→ "Browser panes", so the comment points there.standalone/src/window-recovery.ts:transport.md→ "Persisted session" is now the heading "Persisted session types".lib/src/lib/vscode-message-token.ts: the comment said "the spec section above" explains why the code uses a token and not the CSP nonce.vscode.mdonly marks that rule(rationale). The reasons are indocs/specs/vscode.rationale.md→ "Webview message authentication", so the comment names that file.lib/src/components/wall/browser-url.ts: the header said both helpers are pure string parsing. The file now also holdsbrowserSurfaceUrlandiframeRefusal, andiframeRefusalreads the platform. The header now says so.lib/src/components/motion-test-utils.ts:installFakeFramessaid to call it only at a test file's top level.WorkspaceStrip.test.tsxcalls it inside adescribe, which works because it registersbeforeEach/afterEach. The comment now allows both.scripts/loopback-lint-selftest.mjs: the failure message quoted the clause "A new non-test listener without a guard reference fails the build" fromsecurity-local.md, and a comment said the spec claims the lint scans every JS/TS file. Neither text is in the spec. The message now names the guard-reference half ofS141, and the comment cites only the audit prompt and the lint header, which do make that claim.scripts/security-audit-local.sh: removes a stray "a" in a comment.No test is included because only comments and message text change.
spec-lintpasses, andbash -nandnode --checkpass on the two scripts. The rest ofpnpm testruns in CI.