use std::string_view in string_utils#9005
Open
kroening wants to merge 1 commit into
Open
Conversation
107e7f5 to
a6d99d2
Compare
This introduces std::string_view as a replacement for std::string parameters for the string utility functions in util/string_utils.h, in the hope of avoiding copies of string contents. The change is designed not to break any usage of the functions; C++17 guarantees that there's an implicit conversion from std::string to std::string_view. The exception is a single-charater string constructed from char.
a6d99d2 to
e81b174
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9005 +/- ##
========================================
Coverage 80.55% 80.55%
========================================
Files 1707 1707
Lines 189016 189015 -1
Branches 73 73
========================================
+ Hits 152261 152262 +1
+ Misses 36755 36753 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
std::string_viewas a replacement forstd::stringparameters for the string utility functions inutil/string_utils.h, in the hope of avoiding copies of string contents.The change is designed not to break any usage of the functions; C++17 guarantees that there's an implicit conversion from
std::stringtostd::string_view.