Preparation for PHP 8.4: Rector rules and CI compatibility check#19
Open
agissept wants to merge 6 commits into
Open
Preparation for PHP 8.4: Rector rules and CI compatibility check#19agissept wants to merge 6 commits into
agissept wants to merge 6 commits into
Conversation
agissept
force-pushed
the
feature/preparation-php84
branch
from
7223225 to
6c843fc
Compare
apply rule ExplicitNullableParamTypeRector
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- IronQueue::recreate: add default value to $delay to fix deprecated optional-before-required parameter order in PHP 8.4 - Simplify syntax check CI step so php -l errors print directly to log Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
agissept
force-pushed
the
feature/preparation-php84
branch
3 times, most recently
from
4252897 to
76f6076
Compare
agissept
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--dry-runon changed files onlywithPhpVersion(PhpVersion::PHP_84)inrector.phpExplicitNullableParamTypeRector,AddEscapeArgumentRectorIronQueue::recreate(): optional parameter$queuebefore required$delay— deprecated in PHP 8.4predisandportable-asciito PHP 8.4-compatible versionsChanged files
.github/workflows/pull-request-check.ymlrector.phpcomposer.jsonsrc/Illuminate/**(34 files)Test plan
php84-syntax-checkjob passes on this PR#[Deprecated]attribute?Type🤖 Generated with Claude Code