Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 63.49% 63.50% +0.01%
==========================================
Files 47 47
Lines 6821 6823 +2
Branches 2422 2422
==========================================
+ Hits 4331 4333 +2
Misses 1182 1182
Partials 1308 1308 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
awvwgk
approved these changes
Oct 12, 2026
awvwgk
left a comment
Member
There was a problem hiding this comment.
Fine with this change, note that we do distribute an sdist (via GH release and PyPI release) which ships the parameters.toml in the Python package and does not need this change.
Contributor
Author
Good to know, thanks. Looks like dftd3-python-feedstock and simple-dftd3-feedstock keep aligned on the GH src. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the parameters import for the conda-forge py315 module for Windows after the new layout https://conda-forge.org/blog/2026/09/03/python-315/#a-more-unixy-layout-on-windows . I've patched the
dftd3-pythonconda package and tested it against psi4, so there's no hurry.If there's confidence the
3 * ".."path is only used by conda-forge, I can make this change shorter.