Skip to content

chore: Use AgentExt trait in routing table manager - #218

Merged
blind-oracle merged 4 commits into
mainfrom
igor/use-agentex-trait
Jul 31, 2026
Merged

chore: Use AgentExt trait in routing table manager#218
blind-oracle merged 4 commits into
mainfrom
igor/use-agentex-trait

Conversation

@blind-oracle

@blind-oracle blind-oracle commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Drop redundant code, remove FetchesSubnetInfo trait, use implementation from ic-bn-lib. This also drops a few metrics since they're using data that is now behind API boundaries, but they're not very useful.

@blind-oracle
blind-oracle requested a review from a team as a code owner July 30, 2026 11:40
@zeropath-ai

zeropath-ai Bot commented Jul 30, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to cc47de0.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► src/policy/domain_canister.rs
    Adjust SubnetType handling in DomainCanisterMatcher
Enhancement ► src/routing/ic/route_provider/health.rs
    Add node_list field and integrate ArcSwapOption for NodeList
    Update HealthCheckManager to store and use node_list
Enhancement ► src/routing/ic/route_provider/provider.rs
    Remove RouteProviderManager and related run logic; adjust imports
Enhancement ► src/routing/ic/routing_table_manager.rs
    Introduce SubnetType enum exposure via ic_bn_lib
    Remove legacy subnet info fetcher implementations and related metrics
    Refactor RoutingTableManager to use AgentExt-based fetcher
    Adjust data structures for subnet routing entries to clone SubnetType where needed

This comment was marked as outdated.

@blind-oracle
blind-oracle merged commit 2674133 into main Jul 31, 2026
6 checks passed
@blind-oracle
blind-oracle deleted the igor/use-agentex-trait branch July 31, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants