Skip to content

fix(git): disable filter.lfs.required when git-lfs binary is missing #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skevetter merged 1 commit into from
Jul 30, 2026
Merged

fix(git): disable filter.lfs.required when git-lfs binary is missing #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/tests/up/git_lfs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ func simulateStaleGlobalLFSConfig(t *testing.T) {
runGit(t, home, "config", "--global", "filter.lfs.process", "git-lfs filter-process")
runGit(t, home, "config", "--global", "filter.lfs.smudge", "git-lfs smudge -- %f")
runGit(t, home, "config", "--global", "filter.lfs.clean", "git-lfs clean -- %f")
runGit(t, home, "config", "--global", "filter.lfs.required", "true")
}

// newLFSFixtureRepo creates a repo declaring an LFS-tracked file, using local
Expand All @@ -86,6 +87,7 @@ func newLFSFixtureRepo(t *testing.T) string {
runGit(t, dir, "config", "filter.lfs.clean", "cat")
runGit(t, dir, "config", "filter.lfs.smudge", "cat")
runGit(t, dir, "config", "filter.lfs.process", "")
runGit(t, dir, "config", "filter.lfs.required", "false")

writeFile(
t,
Expand Down
1 change: 1 addition & 0 deletions pkg/git/lfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ var lfsDisableFilterArgs = []string{
flagConfig, "filter.lfs.process=",
flagConfig, "filter.lfs.smudge=cat",
flagConfig, "filter.lfs.clean=cat",
flagConfig, "filter.lfs.required=false",
}

func cloneArgsForLFS() []string {
Expand Down
Loading