Skip to content

chore: harden env handling and package manager config#11

Merged
devrodri-com merged 1 commit into
mainfrom
chore/env-package-manager-hardening
May 13, 2026
Merged

chore: harden env handling and package manager config#11
devrodri-com merged 1 commit into
mainfrom
chore/env-package-manager-hardening

Conversation

@devrodri-com
Copy link
Copy Markdown
Owner

Summary

  • Stop tracking the local .env file while preserving it locally.
  • Add .env.example with the public VITE_GA_ID placeholder.
  • Ignore .env and .env.* while allowing .env.example.
  • Pin the package manager to the current npm version.

Validation

  • npm ci
  • npm run build

Notes

  • package-lock.json was not modified.
  • No dependencies were updated.
  • No app code was changed.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
devrodri Ready Ready Preview, Comment May 13, 2026 2:04am
minisitio-rodrigo Ready Ready Preview, Comment May 13, 2026 2:04am

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4b0c3f0d28

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .env
@@ -1 +0,0 @@
VITE_GA_ID=G-0XMXRJ5KWP No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep default GA ID available for pageview tracking

Removing the only committed VITE_GA_ID value makes usePageview in src/App.tsx exit early (if (!id || !(window as any).gtag) return) on any fresh clone or deployment that does not explicitly inject this env var, so page_view events stop being sent. Because index.html still hardcodes GA initialization, click events can still fire, which creates silently incomplete analytics rather than a clean disable; adding a non-secret default or documenting/validating required env setup would prevent this regression.

Useful? React with 👍 / 👎.

@devrodri-com devrodri-com merged commit 0788743 into main May 13, 2026
4 checks passed
@devrodri-com devrodri-com deleted the chore/env-package-manager-hardening branch May 13, 2026 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant