fix(CEMAS-103): stop leading comma when a dimension fails to resolve

meerkat-browser/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devrev/meerkat-browser",
-  "version": "0.0.135",
+  "version": "0.0.136",
   "dependencies": {
     "tslib": "^2.3.0",
     "@devrev/meerkat-core": "*",

meerkat-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devrev/meerkat-core",
-  "version": "0.0.135",
+  "version": "0.0.136",
   "dependencies": {
     "tslib": "^2.3.0"
   },

meerkat-core/src/cube-measure-transformer/cube-measure-transformer.spec.ts

@@ -120,6 +120,13 @@ describe('cubeMeasureToSQLSelectString', () => {
     );
   });
 
+  it('should not emit a leading comma when an earlier dimension fails to resolve', () => {
+    const dimensions: Member[] = ['temp.unknown_dimension', 'temp.dimension1'];
+    const sqlToReplace = 'SELECT * FROM (SELECT * FROM TABLE_1)';
+    const result = applyProjectionToSQLQuery(dimensions, [], [tableSchema], sqlToReplace);
+    expect(result).toBe(`SELECT  temp__dimension1 FROM (SELECT * FROM TABLE_1)`);
+  });
+
   it('should use aliases when provided', () => {
     const measures: Member[] = ['temp.measure1', 'temp.measure2'];
     const sqlToReplace = 'SELECT * FROM my_table';

meerkat-core/src/cube-measure-transformer/cube-measure-transformer.ts

@@ -98,12 +98,9 @@ const addDimensionToSQLProjection = (
   selectString: string,
   tableSchemas: TableSchema[]
 ) => {
-  if (dimensions.length === 0) {
-    return selectString;
-  }
-  let newSelectString = selectString;
-  for (let i = 0; i < dimensions.length; i++) {
-    const dimension = dimensions[i];
+  const entries: string[] = [];
+
+  for (const dimension of dimensions) {
     const resolved = findSchemaForMember(dimension, tableSchemas);
     if (!resolved) {
       continue;
@@ -122,13 +119,11 @@ const addDimensionToSQLProjection = (
     if (!dimensionSchema) {
       continue;
     }
-    if (i > 0) {
-      newSelectString += ',';
-    }
     // since alias key is expected to have been unfurled in the base query, we can just use it as is.
-    newSelectString += `  ${aliasKey}`;
+    entries.push(`  ${aliasKey}`);
   }
-  return newSelectString;
+
+  return selectString + entries.join(',');
 };
 
 export const getSelectReplacedSql = (sql: string, selectString: string) => {

meerkat-node/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@devrev/meerkat-node",
-  "version": "0.0.135",
+  "version": "0.0.136",
   "dependencies": {
     "@devrev/meerkat-core": "*",
     "@swc/helpers": "~0.5.0",