test(makefile): surface captured RUN_OUT on assert_eq failure#45
Merged
Conversation
The build-pipeline smoke test captured `make _extended-image` output into RUN_OUT but only printed it on the SECOND assertion (the grep for the build-event message). When assert_eq on exit code failed first, RUN_OUT was silently dropped — CI failures became black boxes with no docker build output to diagnose from. Hit this debugging PR #44's Case 5 failure on CI (which passes locally). Adding the output dump unconditionally to assert_eq so future failures are tractable. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The plugin build-pipeline smoke test captures
make _extended-imageoutput into RUN_OUT and only prints it on the SECOND assertion (the grep for the build-event message). Whenassert_eqon exit code fails first, RUN_OUT is silently dropped — CI failures become black boxes.Hit this debugging the post-#44-merge CI failure on main (Case 5 fails on CI, passes locally). With this change, future assert_eq failures dump RUN_OUT so the docker build output is visible.
Test plan