#1884: keep symlinks while unzipping#1924
Merged
hohwille merged 6 commits intoMay 21, 2026
Merged
Conversation
…mlinks and keep existing symlinks in place
…missions + symlinks and for simulated mac and windows to check the isWindows() guard
Collaborator
Coverage Report for CI Build 26212181111Coverage increased (+0.02%) to 70.996%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions197 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
Member
|
This PR looks really great. @satorus awesome that you researched deep and found the magic tricks. 👍 |
hohwille
approved these changes
May 21, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@satorus thanks for analysing and fixing this tricky issue.
Awesome that you also created various zip files with the different scenarios and covered everything perfectly with JUnit. Also your extensive JavaDoc is very helpful to understand this in the future. Great job.👍
Member
|
For retest and setting "QA approved" it would be awesome to also test #797 again with the latest SNAPSHOT on a Mac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1884
Implemented changes:
How to test:
Difficult. One test is to download and install Terraform and then running terraform --version. This shows that at least the file permissiosn still work. See: #835
For manually checking the unzipping, one can add
(@TempDir(cleanup = CleanupMode.NEVER) Path tempDir)to the new test cases. This will create the ideasy-unzipped files in the /tmp/junit-... directories, where one can manually check the unzipped files for correct file permissions and existing symlinks.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal