Skip to content

feat: restore auth controls in new shell - #44

Merged
devjusty merged 9 commits into
mainfrom
feat/auth-controls-new-shell
Sep 24, 2026
Merged

devjusty merged 9 commits into
mainfrom
feat/auth-controls-new-shell

Conversation

@devjusty

Copy link
Copy Markdown
Owner

Summary

  • Restore login and authenticated user menu controls in active AppShell routes.
  • Move auth UI into ui/auth and keep AppShell Auth0-agnostic via an authActions slot.
  • Clear pre-existing frontend lint and typecheck warnings.

Verification

  • Focused Vitest: 31 passed
  • pnpm --filter frontend run lint
  • pnpm --filter frontend run typecheck
  • pnpm --filter frontend run build
  • git diff --check

Build retains existing chunk-size and dynamic/static import warnings.

@netlify

netlify Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for wp-json-discovery ready!

Name Link
🔨 Latest commit 63d6b40
🔍 Latest deploy log https://app.netlify.com/projects/wp-json-discovery/deploys/6ab5874143500b00083d3646
😎 Deploy Preview https://deploy-preview-44--wp-json-discovery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11776b73dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/src/App.tsx
);
const authActions = (
<>
<UserMenu onNavigate={navigateTopLevel} />

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render text only when the avatar is unavailable

For authenticated users with a profile picture, this newly mounts the unchanged UserMenu, whose trigger renders both the avatar and <span>{displayName}</span> (frontend/src/ui/auth/UserMenu.tsx:38-39). That defeats the specified compact authenticated state: the design requires the picture when available and the name/nickname/email fallback otherwise (docs/superpowers/specs/2026-09-24-auth-controls-new-shell-design.md:55-58, :64-67). Update the trigger to omit visible text when an avatar exists while preserving an accessible button label.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 63d6b40. Avatar state now renders only the avatar with an accessible button label; display name remains visible when no avatar is available. Added regression tests for both states.

@devjusty
devjusty merged commit 0ec880b into main Sep 24, 2026
6 checks passed
@devjusty
devjusty deleted the feat/auth-controls-new-shell branch September 24, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant