Repository navigation
feat: restore auth controls in new shell - #44
Conversation
✅ Deploy Preview for wp-json-discovery ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11776b73dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ); | ||
| const authActions = ( | ||
| <> | ||
| <UserMenu onNavigate={navigateTopLevel} /> |
There was a problem hiding this comment.
Render text only when the avatar is unavailable
For authenticated users with a profile picture, this newly mounts the unchanged UserMenu, whose trigger renders both the avatar and <span>{displayName}</span> (frontend/src/ui/auth/UserMenu.tsx:38-39). That defeats the specified compact authenticated state: the design requires the picture when available and the name/nickname/email fallback otherwise (docs/superpowers/specs/2026-09-24-auth-controls-new-shell-design.md:55-58, :64-67). Update the trigger to omit visible text when an avatar exists while preserving an accessible button label.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 63d6b40. Avatar state now renders only the avatar with an accessible button label; display name remains visible when no avatar is available. Added regression tests for both states.
Summary
Verification
Build retains existing chunk-size and dynamic/static import warnings.