Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #2693 by addressing missing font SVG references and mismatched versions reported during validation:
clojure:versions.fonthad["line", "plain"], butplainis an alias oflinedefined inaliases. In Devicon standards, aliases must not be listed inversions.font.versions.fontto["line"].icons/clojure/clojure-original.svgandicons/clojure/clojure-line.svg.csharp:versions.fonthad["plain", "plain-wordmark", "line", "line-wordmark"], butplain-wordmarkandline-wordmarkare font aliases ofplainandline.versions.fontto["plain", "line"].icons/csharp/csharp-original.svg,icons/csharp/csharp-plain.svg, andicons/csharp/csharp-line.svg.junie:icons/junie/junie-plain-wordmark.svgexists on disk and is listed inversions.font, but was omitted fromversions.svg."plain-wordmark"toversions.svg(["original", "original-wordmark", "plain-wordmark"]).testrail:develop(plainremoved fromversions.svgand aliased tooriginal). Verified clean.All modified icons now pass
check_icon.jswith 0 errors.Double check these details before you open a PR
fix: ...)developbranchThis PR closes #2693