petalinuxconfig_xlnx.py: emit disabled UARTs under 'disabled_slaves' - #796
Merged
Conversation
QEMU instantiates a serial port for every UART on the SoC, including disabled ones, and numbers them serial0, serial1, ... by base address. For gen-machine-conf to build a matching QEMU '-serial' line, the syshw data must also list the disabled UARTs. Detect disabled UART nodes the same way as enabled devices (by matching their 'compatible' against the schema's serial driver list) and route them through the existing serial-slave handling into a dedicated 'disabled_slaves' section. Keeping them out of 'slaves' ensures nothing that iterates the slaves (e.g. the Kconfig serial menu) is affected. - Accumulate the serial-compatible set during the existing device_type_map build pass instead of a second loop. - Omit 'ip_name' when a node has no 'xlnx,ip-name' (disabled UARTs are not annotated by the Xilinx SDT flow) rather than emit an empty value. Signed-off-by: Raju Kumar Pothuraju <rajukumar.pothuraju@amd.com>
Contributor
Author
|
No extra reviews are necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QEMU instantiates a serial port for every UART on the SoC, including disabled ones, and numbers them serial0, serial1, ... by base address. For gen-machine-conf to build a matching QEMU '-serial' line, the syshw data must also list the disabled UARTs.
Detect disabled UART nodes the same way as enabled devices (by matching their 'compatible' against the schema's serial driver list) and route them through the existing serial-slave handling into a dedicated 'disabled_slaves' section. Keeping them out of 'slaves' ensures nothing that iterates the slaves (e.g. the Kconfig serial menu) is affected.