lopper: gen_domain_dts: fix MBV32 NUM_IRQS calculation and export it in board_Kconfig.defconfigLopper kconfig changes - #794
Merged
Conversation
The bare else branch reset num_intr to 32 for every non-axi_intc PL peripheral, overwriting the design-specific AXI INTC count. Limit the fixed value of 32 to iomodule IP nodes only. Signed-off-by: Bingi Dinesh kumar <dineshkumar.bingi@amd.com>
Contributor
Author
|
Hi @kedareswararao, Please review the changes. |
kedareswararao
left a comment
kedareswararao
left a comment
Contributor
There was a problem hiding this comment.
Other than unrelated changes rest looks fine please fix those
| ''' Parse isa string and generate Kconfig.soc | ||
| and Kconfig.defconfig based on that | ||
| ''' | ||
| and Kconfig.defconfig based on that |
Contributor
Author
There was a problem hiding this comment.
The unrelated change has been removed
| soc_defconfig_file = os.path.join(sdt.outdir, "Kconfig.defconfig") | ||
| defconfig_kconfig = open(soc_defconfig_file, 'a') | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The unrelated change has been removed
…g.defconfig Export design-specific NUM_IRQS from board_Kconfig.defconfig based on the interrupt controller configuration in the SDT (AXI INTC or IOModule). This addresses the gap where board_Kconfig.defconfig contained only ISA extensions while NUM_IRQS remained in SoC Kconfig.defconfig. Signed-off-by: Bingi Dinesh kumar <dineshkumar.bingi@amd.com>
dbingi-amd
force-pushed
the
lopper-kconfig-changes
branch
from
July 28, 2026 13:39
e904331 to
716ca25
Compare
kedareswararao
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the amba_pl peripheral loop so num_intr = 32 applies only to IOModule IPs (elif val == "iomodule") instead of very non-axi_intc peripheral, preserving design-specific AXI INTC interrupt counts, and extends generate_board_kconfig_defconfig() to write NUM_IRQS into board_Kconfig.defconfig alongside ISA extensions so design specific interrupt configuration is available at the board level