lopper: assists: Model TTC counters as child nodes - #792
Merged
Conversation
Update the TTC node generation logic to model TTC counters as child nodes of the parent TTC device. Previously, the lopper assist generated independent TTC counter nodes. Following review feedback, preserve the TTC node as a container and generate counter@0, counter@1, and counter@2 child nodes. Move interrupt properties from the parent node to the corresponding child counter nodes and add the required parent/child hierarchy. Also update the supported property list to retain the properties required by the generated TTC container node. Signed-off-by: Satya Sri <satyasri.katru@amd.com>
Author
|
@kedareswararao , |
kedareswararao
approved these changes
Jul 28, 2026
kedareswararao
left a comment
kedareswararao
left a comment
Contributor
There was a problem hiding this comment.
Changes looks fine to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the TTC node generation logic based on review feedback to model TTC counters as child nodes of the parent TTC device.
Changes
corresponding child counter nodes.
This aligns the generated Devicetree hierarchy with the TTC hardware organization and the Zephyr TTC counter driver model.