Skip to content

fix(timeline): improve per-point configuration handling for post count - #163

Merged
timothy-mugo merged 2 commits into
mainfrom
fix/-timeline-add-elements
Nov 9, 2026
Merged

timothy-mugo merged 2 commits into
mainfrom
fix/-timeline-add-elements

Conversation

@timothy-mugo

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Bug fix (fix:)
  • New feature (feat:)
  • Breaking change (BREAKING CHANGE:)
  • Refactor / chore (refactor: / chore:)
  • Documentation update (docs:)

Affected package(s)

  • @devgateway/dvz-wp-commons
  • @devgateway/create-wp-customizer
  • @devgateway/upgrade-wp-customizer
  • plugins/wp-react-blocks-plugin
  • plugins/wp-react-custom-api
  • plugins/wp-react-custom-rest-menu
  • Other plugin / theme / Docker (no changeset needed)

Checklist

  • PR title follows Conventional Commits format
  • pnpm build passes locally
  • No hardcoded credentials, internal URLs, client names, or PII introduced
  • Any new dependency has a GPL-2.0-or-later-compatible license (MIT, BSD, Apache-2.0, ISC are all compatible)

Copilot AI lite review requested due to automatic review settings November 9, 2026 10:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified for the timeline configuration-preservation changes.

No open issues 🎉

What changed in this PR

Updates both timeline block editors to preserve per-point configuration when the post count is reduced or later restored.

Changes:

  • Preserve existing configuration entries beyond the current post count.
  • Generate default settings only for missing entries.
  • Apply the behavior consistently to both timeline block variants.
File Description
plugins/​wp-react-blocks-plugin/​blocks/​time-line/​BlockEdit.js Preserves per-point settings while adjusting the timeline post count.
plugins/​wp-react-blocks-plugin/​blocks/​new-time-line/​BlockEdit.js Applies the same configuration-preservation behavior to the newer timeline block.

Review effort: Lite

@timothy-mugo
timothy-mugo merged commit aef08be into main Nov 9, 2026
5 checks passed
@timothy-mugo
timothy-mugo deleted the fix/-timeline-add-elements branch November 9, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants