You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix (new-timeline): Fix new timeline crashing on missing categories - #308
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Two moderate active issues remain: timeline renders can trigger repeated post-fetch requests, and the active marker can remain on the previously selected slide.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
An active moderate issue remains because timeline rerenders create a new categories array, causing unnecessary posts requests even when the filter is unchanged.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Avoid refetching posts when categories are unchanged
This now returns a new array from parse on every render (both the JSON-array path and the comma-separated fallback). PostProvider compares categories by reference (categories != prevProps.categories), while this component re-renders whenever setCurrentSlide runs, so clicking a timeline point dispatches another posts request even though the filter did not change. Return a stable serialized category string (or memoize the parsed value before passing it to PostProvider) so rerenders do not refetch the posts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses