Repository navigation
merge main to tooltips branch - #304
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Several active issues remain, including a critical ReferenceError on API-backed D3 map mounts and additional formatting, reset-state, logging, and prop-tracking bugs.
5 open issues
What changed in this PR
This pull request improves map-data compatibility across Superset, Spring Boot, and WordPress payloads while expanding tooltip support, responsive map behavior, and filter handling.
Changes:
- Adds flexible map parsing for measures, dimensions, nested children, flat aggregates, and extra tooltip columns.
- Adds recursive tooltip variables, currency formatting, row-level color overrides, and Senegal map support.
- Updates post loading, filter behavior, responsive sizing, documentation, package versions, and changelogs.
This pull request requires changes.
| File | Summary | Review status |
|---|---|---|
packages/react-lib/wp-react-lib/src/providers/PostProvider.jsx |
Tracks post type changes when fetching posts. |
Moderate issue: update the stored snapshot after comparisons (3 votes). |
packages/react-lib/wp-react-lib/package.json |
Bumps the WordPress library patch version. | Reviewed |
packages/react-lib/wp-react-lib/CHANGELOG.md |
Documents the PostProvider fix. | Reviewed |
packages/dvz-ui/src/scss/themes/default/_map.scss |
Makes map SVGs fill responsive containers. | Reviewed |
packages/dvz-ui/src/embeddable/tabbedposts/index.jsx |
Normalizes category values and handles missing post types. | Reviewed |
packages/dvz-ui/src/embeddable/map/README.md |
Updates map label font-size documentation. | Nit: document the data-extra-tooltip-columns attribute and behavior (1 vote). |
packages/dvz-ui/src/embeddable/map/mapHelpers.ts |
Removes obsolete device-specific map sizing constants. | Reviewed |
packages/dvz-ui/src/embeddable/map/MapDataFrame.jsx |
Supports multiple measure, dimension, nested-child, and flat-payload formats. | Reviewed |
packages/dvz-ui/src/embeddable/map/map.jsx |
Refines map dimensions, positioning, and responsive label scaling. | Reviewed |
packages/dvz-ui/src/embeddable/map/index.jsx |
Adds Senegal support, extra tooltip columns, and filter normalization. | Reviewed |
packages/dvz-ui/src/embeddable/filter/index.tsx |
Improves filter initialization when options become available. | Reviewed |
packages/dvz-ui/src/embeddable/filter-reset-button/index.tsx |
Corrects changed-filter detection logic. | Moderate issue: compare empty arrays instead of returning early (2 votes). |
packages/dvz-ui/src/embeddable/data/D3MapDataProvider.jsx |
Adds extra-column loading and editor parameter refresh handling. | Critical issue: undeclared extraTooltipColumns causes API-backed maps to throw; moderate issue: remove or gate props logging (4 and 3 votes). |
packages/dvz-ui/src/embeddable/d3Map/Utils.jsx |
Adds recursive tooltip-variable extraction and color override helpers. | Reviewed |
packages/dvz-ui/src/embeddable/d3Map/Tooltip.jsx |
Adds normalized tooltip variables and currency formatting. | Moderate issue: capture the full currency expression, including spaces and symbols (4 votes). |
packages/dvz-ui/src/embeddable/d3Map/README.md |
Documents tooltip templates, formatting, color overrides, and extra API columns. | Reviewed |
packages/dvz-ui/src/embeddable/d3Map/Legends.jsx |
Includes extra tooltip columns in legend requests. | Reviewed |
packages/dvz-ui/src/embeddable/d3Map/LatLongLayer.jsx |
Adds expanded tooltip metadata and extra-column requests. | Reviewed |
packages/dvz-ui/src/embeddable/d3Map/FlowLayer.jsx |
Adds improved flow tooltips and extra-column requests. | Reviewed |
packages/dvz-ui/src/embeddable/d3Map/DataLayer.jsx |
Adds nested tooltip variables, color overrides, and extra-column requests. | Reviewed |
packages/dvz-ui/package.json |
Bumps the main UI package version. | Reviewed |
packages/dvz-ui/CHANGELOG.md |
Documents the map, tooltip, filter, and compatibility changes. | Reviewed |
Review effort: Lite
| if (!waitForFilters || editing) { | ||
| console.log('📥 [D3 Map DataProvider] Initial data load triggered', { app, editing, waitForFilters }); | ||
| this.loadData({ app, source, store, params, group }); | ||
| this.loadData({ app, source, store, params, group, includeColumns: extraTooltipColumns }); |
| const percentExpresion = /(\+?\%)[\(]([A-z0-9,.,-]+)\)/gi | ||
| const numericExpresion = /(\+?\#)[\(]([A-z0-9,.,-]+)\)/gi | ||
| const compactExpresion = /(\+?\#C)[\(]([A-z0-9,.,-]+)\)/gi | ||
| const currencyExpresion = /(\$)[\(]([A-Za-z0-9,.]+)\)/gi |
| waitForFilters, | ||
| editing | ||
| } = this.props | ||
| console.log("Current props in d3MapDataProvider", this.props); |
Comment on lines
+38
to
39
| return initialValues.length !== filteredApplied.length || | ||
| !initialValues.every(v => filteredApplied.includes(v)); |
Comment on lines
+33
to
39
| const prevProps = useRef({type, categories, locale, slug, taxonomy, page, perPage, search}).current; | ||
|
|
||
| useEffect(() => { | ||
|
|
||
| if (categories != prevProps.categories || locale != prevProps.locale || slug != prevProps.slug || | ||
| if (type != prevProps.type || categories != prevProps.categories || locale != prevProps.locale || slug != prevProps.slug || | ||
| taxonomy != prevProps.taxonomy || page != prevProps.page || perPage != prevProps.perPage || search != prevProps.search | ||
| ) { |
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Still open (5)
- 🔴 packages/dvz-ui/src/embeddable/data/D3MapDataProvider.jsx#L33 —
extraTooltipColumnsis not destructured fromthis.props, so both API load paths evaluate an… - 🟠 packages/react-lib/wp-react-lib/src/providers/PostProvider.jsx#L39 —
useRef(...).currentcaptures only the first render's values, and this effect never updates that… - 🟠 packages/dvz-ui/src/embeddable/filter-reset-button/index.tsx#L39 — The new comparison is still skipped whenever the user clears a filter: the preceding early return…
- 🟠 packages/dvz-ui/src/embeddable/data/D3MapDataProvider.jsx#L69 — This logs the entire provider props object on every update. The props include fetched
data, CSV… - 🟠 packages/dvz-ui/src/embeddable/d3Map/Tooltip.jsx#L7 — The lookup below supports currency names and symbols, and the README advertises
codeOrName, but…
An error occurred while trying to automatically change base from
fix/make-tooltips-centered
to
main
November 3, 2026 14:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


…ibility## Description
Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-ui-react@devgateway/wp-react-libexampleonly (no changeset needed)Checklist
pnpm changeset) for any change to a published packagepnpm buildpasses locallypnpm --filter @devgateway/* typecheckpasses