feat(oidc-provider): make OidcCredentialProvider cheaply cloneable (shareable warm cache)#69
Merged
Merged
Conversation
…ply cloneable Put the cache's entries map behind an Arc and derive Clone on CredentialCache and OidcCredentialProvider. Cloning a provider now shares the same cache, so a runtime that rebuilds its dispatch chain per request (e.g. a Cloudflare Worker) can hold one provider in a shared/static slot and reuse it across requests — keeping the credential cache warm instead of re-minting a JWT and re-running AssumeRoleWithWebIdentity on every call. No behavior change for existing single-instance use. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚀 Latest commit deployed to https://multistore-proxy-pr-69.development-seed.workers.dev
|
alukach
added a commit
that referenced
this pull request
Jun 20, 2026
Resolve conflicts after main dissolved `backend-federation` (#67) and shipped its own `oidc-provider` credential cache (#69). PR #61 added single-flight + proactive-refresh in a standalone `credential-cache` crate, built on the now-removed `backend-federation` crate and the pre-rename `FederatedCredentials` type. Main has since dissolved `backend-federation` (value type -> core as `BackendCredentials`, AWS exchange -> `oidc-provider`) and added its own plain TTL `CredentialCache` in `oidc-provider/src/cache.rs`. Rather than resurrect a separate cache crate (the speculative-separate- crate pattern #67 deliberately removed), fold PR #61's behavior into main's existing cache: - oidc-provider/src/cache.rs: replace the get/put TTL cache with a single-flight, proactively-refreshing `get_or_fetch(key, fetch)` over `BackendCredentials`. A per-key `futures::lock::Mutex` serializes concurrent refreshes; values are shared via `Arc`; the cache stays `Clone` for the cheaply-cloneable provider (#69). - oidc-provider/src/lib.rs: `get_credentials` now goes through `get_or_fetch`; drop the external crate, the `CloudCredentials`/ `Expiring` glue, and the `now` parameter (the cache reads `Utc::now()` internally, matching main and the rest of the workspace). - Drop crates/credential-cache and crates/backend-federation and their workspace + manifest entries; add `futures` to oidc-provider for the async lock. - docs/architecture/caching.md: describe the cache as oidc-provider's, not a standalone crate; drop the obsolete "caller passes now" note. Verified: cargo check (native default-members) + cargo check -p multistore-cf-workers --target wasm32; oidc-provider tests 31 default / 39 azure,gcp; clippy clean on oidc-provider; cargo fmt. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ClonetoOidcCredentialProviderandCredentialCache(entries behind anArc), so a runtime that rebuilds its dispatch chain per request (e.g. a Cloudflare Worker) can hold one provider in a shared/staticslot and reuse it — keeping the credential cache warm instead of re-minting + re-running AssumeRoleWithWebIdentity on every call. No behavior change for single-instance use. Consumed by source-cooperative/data.source.coop#147.🤖 Generated with Claude Code